Skip to content

Leaves - Katie K. #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

KKennedyCodes
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both methods work. Well done. You hit the learning goals here. See my notes on time complexity, but nice work!

raise NotImplementedError, "Not implemented yet"
item_list = []
list.each_with_index do |item|
if item_list.include?(item) == false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .include? has to traverse the entire array it should take O(n) time, and since it's nested into a loop the method is an O(n2) algorithm.

end

# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(n2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually O(m * n) where m is the number of letters in the strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants